Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): move invalidation in useRegister to be called on success #6658

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arndom
Copy link
Contributor

@arndom arndom commented Jan 23, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

On unsuccessful registration, the page refreshes/re-renders

What is the new behavior?

On unsuccessful registration, the page remains the same and only shows error.

fixes (issue)
#6639

Notes for reviewers

  • I attempted to write a test for this but found it difficult to mock window.location.reload to see if it had been called.

@arndom arndom requested a review from a team as a code owner January 23, 2025 14:28
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 7179ac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@refinedev/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7179ac6
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/6792521e2e01a500087f54e5
😎 Deploy Preview https://deploy-preview-6658--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] auth provider's check method triggering unwanted refresh with XHR call
2 participants