Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.7 #40

Open
ejholmes opened this issue Jun 2, 2016 · 0 comments
Open

Go 1.7 #40

ejholmes opened this issue Jun 2, 2016 · 0 comments

Comments

@ejholmes
Copy link
Contributor

ejholmes commented Jun 2, 2016

Go 1.7 brings native support for context.Context, most importantly within net/http. We should make appropriate changes to pkg/httpx to use the standard http.Handler interface.

The major advantage will be that we can use any http.Handler middleware/router (e.g. negroni, gorilla mux), without having to re-implement it to support the httpx.Handler interface.

Also, for outgoing requests, http.Request now natively supports cancellations from the context (e.g. _ cancel := context.WithCancel(req.Context()); cancel()) so we no longer have to re-implement http.Client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant