Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the mod for translation #9

Open
remmintan opened this issue Jan 25, 2024 · 4 comments
Open

Prepare the mod for translation #9

remmintan opened this issue Jan 25, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@remmintan
Copy link
Owner

Describe the feature you'd like to see
There are a lot of hardcoded values in the mod source code that are used to display messages in the interface.
Because the values are hardcoded we can't translate the mod properly.

The hardcoded value example Text.literal:
hardcoded value

we need to convert such values to translatable text pieces like this one Text.translatable:
image
image

This is done in three steps:

  1. Find any Text.literal
  2. Take text from it to a new key in the resources file resources/assets/minefortress/lang/en_us.json
  3. Replace Text.literal with Text.translatable with that key

Please feel free to refer to these issues in any PR where you make such changes. When all texts are moved to translation files we will close this issue.

@remmintan remmintan added enhancement New feature or request help wanted Extra attention is needed labels Jan 25, 2024
@remmintan remmintan added the good first issue Good for newcomers label Jan 27, 2024
@ozgurozbek
Copy link

Is it okay if I take this issue and try to complete? Deadline planned?

@LeMeuble
Copy link
Contributor

If I want to add a translation file, should I make a fork for it, or just push it on master ?

@ArtemBay
Copy link

If I want to add a translation file, should I make a fork for it, or just push it on master ?

Yes, check this PR #14

@remmintan
Copy link
Owner Author

Is it okay if I take this issue and try to complete? Deadline planned?

No deadline, but please open PR early, so your work will be visible and also it will be visible that the PR is not abandoned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants