Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mob start timer starts timer with zero minutes if you add a parameter which is not a number #344

Closed
hollesse opened this issue Nov 18, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@hollesse
Copy link
Member

When I do mob timer notanumber this will start a timer with 0 Minutes and directly say mob next. This behavior also applies to mob start notanumber.

In my opinion it should work like this:

mob timer notanumber

  • should fail with an error message

`mob start notanumber``

  • If the configuration MOB_TIMER is set, this value should be used instead and a warning should be printed
  • if configuration MOB_TIMER is not set, a warning should be printed

mob start and MOB_TIMER="notanumber"

  • a warning should be printed

@simonharrer please add your feedback!

@hollesse hollesse added the bug Something isn't working label Nov 18, 2022
@simonharrer
Copy link
Member

No strong opinion here. It’s okay I guess.

@gregorriegler
Copy link
Collaborator

I agree with everything but using an existing MOB_TIMER setting on mob start notanumber.
When somebody write notanumber as a command I assume they tried to use this number, but made a mistake typing it.
In that case, using MOB_TIMER would not be what they intended to do.

This was referenced Mar 24, 2024
@hollesse
Copy link
Member Author

fixed with #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants