Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page progress tracker not working #31

Open
j-norwood-young opened this issue Oct 14, 2019 · 2 comments
Open

Page progress tracker not working #31

j-norwood-young opened this issue Oct 14, 2019 · 2 comments
Assignees

Comments

@j-norwood-young
Copy link

remplib.tracker.post(this.url + "/track/pageview", params);

This line should be this.post(this.url + "/track/pageview", params);

@rootpd
Copy link
Member

rootpd commented Oct 15, 2019

Not necessarily. The sendTrackedProgress function is being used within event handlers and this is not refering to remplib.tracker object there, but to the context of emitted event.

That's why we rather used remplib.tracker.post which always points to the right function and doesn't get confused by context.

Is current implementation causing you any issues?

@rootpd rootpd self-assigned this Oct 15, 2019
@j-norwood-young
Copy link
Author

My current implementation was not posting any events until I changed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants