Proper caching and mounting with Turbolinks 5 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really sure why the specs are failing... It seems |
|
By forcing |
sevos
reviewed
Apr 10, 2017
| @@ -40,8 +40,7 @@ const ujs = { | |||
| }, | |||
|
|
|||
| turbolinks5(onMount, onUnmount) { | |||
| this.handleEvent('turbolinks:load', onMount, { once: true }) | |||
| this.handleEvent('turbolinks:render', onMount) | |||
| this.handleEvent('turbolinks:load', onMount) | |||
There was a problem hiding this comment.
Please, before making a change read through this
This approach is just wrong if you use turbolinks caching feature
sevos
reviewed
Apr 10, 2017
| @@ -69,7 +69,7 @@ const WebpackerReact = { | |||
| const component = registeredComponents[className] | |||
|
|
|||
| if (component) { | |||
| if (node.innerHTML.length === 0) this.render(node, component) | |||
| this.render(node, component) | |||
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Changes:
Follow the pattern of react-rails and always mount components on
turbolinks:loadwhether initial HTML exists or not.Please ensure that:
rubocopis all greencd javascript/webpacker_react-npm-module/ && yarn lintis all green