Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render failed when using customer theme #1

Open
Aithosa opened this issue Nov 25, 2024 · 1 comment
Open

Render failed when using customer theme #1

Aithosa opened this issue Nov 25, 2024 · 1 comment

Comments

@Aithosa
Copy link

Aithosa commented Nov 25, 2024

In github workflow,

      - name: RenderCV
        run: |
          cd src
          cv_file=$(find .  -maxdepth 1 -type f -name "*_CV.yaml" | head -n 1)
          if [ -z "$cv_file" ]; then
            echo "No RenderCV file found!"
            exit 1
          fi
          cd ..
          rendercv render src/$cv_file --pdf-path ${cv_file%.yaml}.pdf --markdown-path README.md --latex-path ${cv_file%.yaml}.tex

When I use customer theme, rendercv can't find theme folder after cd .., because current path is not in src/
Perhaps should:

  • Add a parameter for rendercv render to locate theme folder.
  • Use a specific fix folder to contain all theme folders.
  • Copy theme folder to root path of the project after cd ... But we don't know the name of customer theme.

By the way, this workflow can only render one yaml. If I have several yaml files in src/, the others will be ignored. should we use a for loop to render all yaml?

@tobybaratta
Copy link

I like the specific folder for theme folders (just themes?), since that would be extremely easy to read.

I think with just a CLI flag, you'll end up with a lot of issues getting made with people having this same problem, whereas a theme folder would be pretty clear.

For the workflow, I think it'd be great if it could take a (or many) yaml files. Maybe a --all to use all of the different files one could have (and default to this), and otherwise have a -filename resume.yaml flag for if someone only wants a specific one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants