Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mootools + jQuery + easyPieChart #66

Open
falahati opened this issue Jan 12, 2014 · 5 comments
Open

Mootools + jQuery + easyPieChart #66

falahati opened this issue Jan 12, 2014 · 5 comments
Labels

Comments

@falahati
Copy link

Hi Robert,

We are using your code in a site where we have jQuery and Mootools side by side and unfortunately your script failed to work in this environment.

Here is an example:
http://jsfiddle.net/6ZdNZ/

Error is:
TypeError: this.renderer.draw is not a function

At:
// initial draw
this.renderer.draw(currentValue);

@falahati
Copy link
Author

Real problem is here:
options[i] = options[i].bind(this);

I temporary solved it with:
if (typeof(options[i]) === 'function' && i != 'renderer') {

Until you find a better solution.

@mrzmyr
Copy link
Collaborator

mrzmyr commented Jan 29, 2014

We would appreciate if you create a PR to fix it.

@ghost ghost assigned mrzmyr Jan 29, 2014
@falahati
Copy link
Author

It is not a real fix. I believe you need to find a better solution based on what happening there. You probably need to see how mootools break bind() method and then rewrite bind() method in next line of your code in the way that it can be executed when we have mootools and jQuery side by side.

@rendro
Copy link
Owner

rendro commented Jan 30, 2014

You should probably open an issue for mootools, that they should not break native JavaScript methods.

Having a fix for every possible other third party library should not be in the source of this plugin.

@JSMyeong
Copy link

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants