Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trackColor parameter with border around it #90

Open
RempelOliveira opened this issue Apr 13, 2014 · 8 comments
Open

trackColor parameter with border around it #90

RempelOliveira opened this issue Apr 13, 2014 · 8 comments
Assignees

Comments

@RempelOliveira
Copy link

@rendro Adjusted the code on file "jquery.easypiechart.js" to the trackColor parameter not having edges into your around when background of div is differs trackColorcolor of.

As the pictures below ...

jquery easypiechart js

The ideal would be to change for all files and create a new version for download.
I sent the file by email to [email protected]!

@mrzmyr
Copy link
Collaborator

mrzmyr commented May 6, 2014

Can you post the code example here or even better can you create a pull request for it ?

It seems that this is the same problem described in #81.

@RempelOliveira
Copy link
Author

@mrzmyr @rendro The author should review the code before that. I did not make this change for other plugins, such as angular e vanilla js. I made this change in just one jquery.easypiechart.js file. Of course it is enough to guide them to resolve this issue according to your need.

If I make an pullRequest there will be no problems as to what I described above?

@mrzmyr
Copy link
Collaborator

mrzmyr commented May 6, 2014

If you make a PR i can dive in to it and bringt into the other files so Robert doesn't have the effort to review it.

@RempelOliveira
Copy link
Author

push to master?

@mrzmyr
Copy link
Collaborator

mrzmyr commented May 6, 2014

  1. Fork the project
  2. Clone your fork
  3. create a feature branch
  4. push branch to your feature branch
  5. create pull request

RempelOliveira pushed a commit to RempelOliveira/easy-pie-chart that referenced this issue May 6, 2014
I changed small things on demo files to display this adjustments.
@RempelOliveira
Copy link
Author

Create #92.

@mrzmyr
Copy link
Collaborator

mrzmyr commented May 6, 2014

@rendro
Copy link
Owner

rendro commented May 6, 2014

I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants