From 97e9665de3b0bfba35f365e2f7be0b984c50c5b9 Mon Sep 17 00:00:00 2001
From: Brian Vaughn <brian.david.vaughn@gmail.com>
Date: Fri, 5 Jul 2024 10:48:55 -0400
Subject: [PATCH 1/2] Remove filter function from test utils config

---
 packages/test-utils/src/reporter.ts | 10 +---------
 packages/test-utils/src/types.ts    |  8 +++-----
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/packages/test-utils/src/reporter.ts b/packages/test-utils/src/reporter.ts
index 36d44220..95a6cf41 100644
--- a/packages/test-utils/src/reporter.ts
+++ b/packages/test-utils/src/reporter.ts
@@ -224,7 +224,6 @@ export default class ReplayReporter<
   private _apiKey?: string;
   private _pendingWork: Promise<PendingWork | undefined>[] = [];
   private _upload = false;
-  private _filter?: (r: RecordingEntry<TRecordingMetadata>) => boolean;
   private _minimizeUploads = false;
   private _uploadableResults: Map<string, UploadableTestResult<TRecordingMetadata>> = new Map();
   private _testRunShardIdPromise: Promise<TestRunPendingWork> | null = null;
@@ -355,8 +354,6 @@ export default class ReplayReporter<
       config.runTitle ||
       getFallbackRunTitle();
 
-    this._filter = config.filter;
-
     // RECORD_REPLAY_METADATA is our "standard" metadata environment variable.
     // We suppress it for the browser process so we can use
     // RECORD_REPLAY_METADATA_FILE but can still use the metadata here which
@@ -425,14 +422,12 @@ export default class ReplayReporter<
       baseMetadata: this._baseMetadata,
       upload: this._upload,
       hasApiKey: !!this._apiKey,
-      hasFilter: !!this._filter,
     });
 
     mixpanelAPI.trackEvent("test-suite.begin", {
       baseId: this._baseId,
       runTitle: this._runTitle,
       upload: this._upload,
-      hasFilter: !!this._filter,
     });
 
     if (!this._apiKey) {
@@ -1092,10 +1087,7 @@ export default class ReplayReporter<
     }
 
     this._pendingWork.push(
-      ...toUpload
-        .flatMap(result => result.recordings)
-        .filter(r => (this._filter ? this._filter(r) : true))
-        .map(r => this._uploadRecording(r))
+      ...toUpload.flatMap(result => result.recordings).map(r => this._uploadRecording(r))
     );
   }
 
diff --git a/packages/test-utils/src/types.ts b/packages/test-utils/src/types.ts
index f6a6eddd..fb0f3ba3 100644
--- a/packages/test-utils/src/types.ts
+++ b/packages/test-utils/src/types.ts
@@ -45,11 +45,9 @@ export type UploadOptions = {
 export interface ReplayReporterConfig<
   TRecordingMetadata extends UnstructuredMetadata = UnstructuredMetadata
 > {
-  runTitle?: string;
-  metadata?: Record<string, any> | string;
+  apiKey?: string;
+  metadata?: TRecordingMetadata;
   metadataKey?: string;
+  runTitle?: string;
   upload?: UploadOptions | boolean;
-  apiKey?: string;
-  /** @deprecated Use `upload.minimizeUploads` and `upload.statusThreshold` instead */
-  filter?: (r: RecordingEntry<TRecordingMetadata>) => boolean;
 }

From d7e0e9fd40f17de663af4e4b370f6c0b3f464785 Mon Sep 17 00:00:00 2001
From: Brian Vaughn <brian.david.vaughn@gmail.com>
Date: Fri, 5 Jul 2024 10:55:14 -0400
Subject: [PATCH 2/2] Create sharp-chicken-tickle.md

---
 .changeset/sharp-chicken-tickle.md | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 .changeset/sharp-chicken-tickle.md

diff --git a/.changeset/sharp-chicken-tickle.md b/.changeset/sharp-chicken-tickle.md
new file mode 100644
index 00000000..67d2dbe6
--- /dev/null
+++ b/.changeset/sharp-chicken-tickle.md
@@ -0,0 +1,6 @@
+---
+"@replayio/cypress": major
+"@replayio/playwright": major
+---
+
+Remove deprecated `filter` function from test config