From 69c282c819d8c35774d19358e7a1d317da092984 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1sp=C3=A1r=20Nagy?= Date: Wed, 22 Jan 2025 09:33:28 +0100 Subject: [PATCH 1/2] Hide FluentAssertions from new project wizard --- .../Dialogs/AddNewReqnrollProjectDialog.xaml | 2 +- .../UI/ViewModels/AddNewReqnrollProjectViewModel.cs | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Reqnroll.VisualStudio.UI/Dialogs/AddNewReqnrollProjectDialog.xaml b/Reqnroll.VisualStudio.UI/Dialogs/AddNewReqnrollProjectDialog.xaml index 1bd4cea0..db226e1a 100644 --- a/Reqnroll.VisualStudio.UI/Dialogs/AddNewReqnrollProjectDialog.xaml +++ b/Reqnroll.VisualStudio.UI/Dialogs/AddNewReqnrollProjectDialog.xaml @@ -251,7 +251,7 @@ SelectionChanged="TestFramework_SelectionChanged" /> - + diff --git a/Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs b/Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs index 6a427637..50c42a64 100644 --- a/Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs +++ b/Reqnroll.VisualStudio/UI/ViewModels/AddNewReqnrollProjectViewModel.cs @@ -11,7 +11,7 @@ public class AddNewReqnrollProjectViewModel : INotifyPropertyChanged { DotNetFramework = Net8, UnitTestFramework = MsTest, - FluentAssertionsIncluded = true + FluentAssertionsIncluded = false }; #endif private string _dotNetFramework = Net8; @@ -27,7 +27,10 @@ public string DotNetFramework } public string UnitTestFramework { get; set; } = MsTest; - public bool FluentAssertionsIncluded { get; set; } = true; + // FluentAssertions suggestion is temporarily hidden from the UI as it is not free for commercial use anymore. + // See https://xceed.com/fluent-assertions-faq/ + // Maybe we could consider suggesting https://github.com/shouldly/shouldly instead. + public bool FluentAssertionsIncluded { get; set; } = false; public ObservableCollection TestFrameworks { get; } = new(new List { "MSTest", "NUnit", "xUnit" }); public event PropertyChangedEventHandler PropertyChanged; From 2dedb8d079414c8d2e32cdbab46adb6d3d1dad7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1sp=C3=A1r=20Nagy?= Date: Wed, 22 Jan 2025 09:46:55 +0100 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4edc3643..f648a6aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Improvements: +* Suggestion for adding [FluentAssertions](https://github.com/fluentassertions/fluentassertions) on the new project wizard screen has been removed to avoid confusions, because FluentAssertion does not offer free use for commercial projects anymore. (#60) + ## Bug fixes: * Fix: Error message box when creating feature file with space in its name (#50)