Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array.getUnsafe does not throw Not_found if index doesn't exist in array #172

Open
dsiu opened this issue Dec 30, 2023 · 1 comment
Open

Array.getUnsafe does not throw Not_found if index doesn't exist in array #172

dsiu opened this issue Dec 30, 2023 · 1 comment

Comments

@dsiu
Copy link

dsiu commented Dec 30, 2023

According to Core__Array.resi, Array.getUnsafe should throw Not_found if the index is out of bounds. However, this is not the case; it returns undefined instead.

ReScript Playground Link

https://github.com/rescript-association/rescript-core/blob/d5904bd82ce2fe77ad66619e66ae5ef935eb115f/src/Core__Array.resi#L811-L830
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Array.getUnsafe doesn't throw Not_found if index doesn't exist in *array* Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in *array* Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe doesn't throw Not_found if index doesn't exist in array Array.getUnsafe does not throw Not_found if index doesn't exist in array Dec 30, 2023
@dsiu dsiu changed the title Array.getUnsafe does not throw Not_found if index doesn't exist in array Array.getUnsafe does not throw Not_found if index doesn't exist in array Dec 30, 2023
dsiu added a commit to dsiu/rescript-stdlib-fp that referenced this issue Dec 30, 2023
@dsiu
use get and set from RescriptCore for zero cost binding. use Belt…
52fa4a3 
…'s `getExn` for `getUnsafe` instead of RescriptCore since there is a bug in RescriptCore's `getUnsafe` not raising `Not_Found` (see: rescript-lang/rescript-core#172)
@DZakh
Copy link
Contributor

DZakh commented Dec 31, 2023

Fixed by #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsiu @DZakh