Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code. #7312

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Remove some dead code. #7312

merged 8 commits into from
Feb 25, 2025

Conversation

cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Feb 22, 2025

Remove some dead code while reanalyze sill works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: edcd921 Previous: 80744a5 Ratio
Parse RedBlackTree.res - time/run 2.16054356 ms 1.87223692 ms 1.15
Print RedBlackTree.res - time/run 3.3749803999999997 ms 2.9391152133333334 ms 1.15
Print RedBlackTreeNoComments.res - time/run 3.1506094266666667 ms 2.693127673333333 ms 1.17
Parse Napkinscript.res - time/run 71.03777063999999 ms 60.98575317999999 ms 1.16
Print Napkinscript.res - time/run 111.94847823333332 ms 102.03488166 ms 1.10
Parse HeroGraphic.res - time/run 8.08245984 ms 7.62831228 ms 1.06
Print HeroGraphic.res - time/run 13.695776059999998 ms 12.308145193333333 ms 1.11

This comment was automatically generated by workflow using github-action-benchmark.

@cristianoc cristianoc requested review from cknitt and zth February 22, 2025 18:53
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cristianoc cristianoc merged commit 313f16f into master Feb 25, 2025
20 checks passed
@cristianoc cristianoc deleted the dead_code branch February 25, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants