Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popover attributes #7317

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dkirchhof
Copy link

Adds popover, popoverTarget and popoverTargetAction to JsxDOM.domProps

dkirchhof and others added 3 commits February 26, 2025 20:25
Co-authored-by: Florian Verdonck <[email protected]>
Co-authored-by: Florian Verdonck <[email protected]>
Co-authored-by: Florian Verdonck <[email protected]>
@dkirchhof
Copy link
Author

🤔 Do I have to write the Completion.res.txt stuff manually or is there a script to generate it?

@nojaf
Copy link
Collaborator

nojaf commented Feb 26, 2025

Try running make test inside tests/analysis_tests. (Or something along those lines, on my phone now)

@dkirchhof
Copy link
Author

Unfortunatelly I don't get the toolchain running. Probably my python version is too new.
I didn't want to put much effort into this small change. Feel free to close this PR or maybe someone else could fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants