-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with monorepo support regarding gentype and commonjs build #146
Comments
Gentype will work with the next 11.x release of the rescript compiler. |
Thanks. Unfortunately it seems updating to latest ReScript version changes nothing in my test repository. Both issues remain. I updated the test repo to confirm this. |
I tried with your repo, if you add the "gentypeconfig" to the root |
Ah, of course I did not test that combination of configs this time. Thanks, now it indeed works. It required running However building to multiple targets is another long-term issue that still exists. I wonder if it is even supposed to work, and what are the implications if it will not. E.g. is the support for commonjs target still considered as necessary? Personally I use it to run some part of the code to generate pdf files on node. But maybe node (or some other runtime) can nowadays properly work with esm target too, I haven't recently checked. |
Maybe I'm doing something wrong here, but it appears neither commonjs files (with
in-source: false
) nor gentyped files are being generated. At least not in the monorepo enviroment.Here's a fairly minimal monorepo to demonstrate the issue
https://github.com/TomiS/rewatch-test
The text was updated successfully, but these errors were encountered: