Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging In #6

Closed
simonv3 opened this issue Apr 11, 2022 · 1 comment
Closed

Logging In #6

simonv3 opened this issue Apr 11, 2022 · 1 comment
Labels
needs: api Needs something changed on the resonate API

Comments

@simonv3
Copy link
Collaborator

simonv3 commented Apr 11, 2022 •
edited
Loading

Need to have a conversation with one of the resonate devs about how to use logging in, and whether it's even possible to log in using oauth within electron

There's some existing issues with the log-in flow: resonatecoop/stream#225
@simonv3 simonv3 added the needs: api Needs something changed on the resonate API label Apr 11, 2022
@simonv3
Copy link
Collaborator Author

simonv3 commented Apr 11, 2022 •
edited
Loading

This is probably not going to be trivial, but worth looking at this https://github.com/openid/AppAuth-JS and https://auth0.com/blog/securing-electron-applications-with-openid-connect-and-oauth-2/

Edit: looks I could get this working with sending password + username to the v1 api, but that obviously won't continue working, but it's good enough for now!

simonv3 added a commit that referenced this issue Apr 11, 2022
@simonv3
feat: add logging in, to do with #6
94869eb
simonv3 added a commit that referenced this issue Apr 11, 2022
@simonv3
feat: add ability to log out #6
ac251ba
@simonv3 simonv3 closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs: api Needs something changed on the resonate API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonv3