-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version command #298
Comments
Version can be derived from the Git Tag, but not necessarily required for the mvp. |
kindly assign this to me |
@rishirishhh - don't hesitate to reach out for any clarification or to chat about requirements and/or design! |
@rishirishhh - are you still interested in working on this? |
Hi, I already see this opened PR: #342 Is this still going? Can I take inspiration from this code or this solution is not valid? |
Just closed that PR for being stale. I think we can take inspiration from the ldflags, but simplify things a little bit. Here's what I'm thinking. Add the following to the root command: var (
cfgFile string
version string = "unknown"
)
var rootCmd = &cobra.Command{
Use: "resonate",
Short: "Resonate: distributed async await",
Version: version,
} Then we can build resonate with an ldflag like this:
Most of the work will involve updating the build scripts to set the version accordingly. What do you think about the following strategy?
|
Hi, I will look into this |
It would be nice to see the version of resonate I have installed locally.
The version is tied to the git tag and can be set via build flags in our release pipeline, we should assert that the git tag matches the version in our release pipeline.
resonate --version
The text was updated successfully, but these errors were encountered: