Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback cli command #435

Open
dfarr opened this issue Oct 3, 2024 · 13 comments
Open

Add callback cli command #435

dfarr opened this issue Oct 3, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dfarr
Copy link
Member

dfarr commented Oct 3, 2024

Create a callback associated with a promise.

Commands:

  • create

Examples:

resonate callbacks create --promise-id foo --root-promise-id bar --timeout 1h --recv default

A receiver can be either a string or an object, an object must always have a type and data.

  • logical as string (eg: "default")
  • physical as url string (eg: "poll://default/6fa89b7e-4a56-40e8-ba4e-78864caa3278")
  • physical as object (eg: {"type": "poll", "data": {"group": "default", "id": "6fa89b7e-4a56-40e8-ba4e-78864caa3278"}}

See promises and schedules for a reference.

@dfarr dfarr added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2024
@Madraceee
Copy link
Contributor

Hey, this project seems interesting. Can I take up this issue to start contributing to this repo?

@dfarr
Copy link
Member Author

dfarr commented Oct 4, 2024

Of course! Thanks so much @Madraceee, let me know if I can help

@Madraceee
Copy link
Contributor

I will go through the repo and start working asap!!

@Madraceee
Copy link
Contributor

@dfarr If my understanding is right , I have to make a new command which calls the callback functions from "pkg/client/v1/v1.go" ?

@dfarr
Copy link
Member Author

dfarr commented Oct 5, 2024

Yes that's correct! The parameters to that call correspond to the flags the command should expose, as detailed above, the only tricky parameter is recv which can be either a string or an object as detailed above.

@Madraceee
Copy link
Contributor

Got it
I will work on this

@Madraceee
Copy link
Contributor

Madraceee commented Oct 7, 2024

I have two doubts

  1. What should be the contentType when sending default or a url?

@Madraceee
Copy link
Contributor

Other than the contentType part,
I have written the code. I am still learning the whole functionality, so can you look at my code and let me know if any changes has to be done?
I can push the changes if you are okay with it.

@TusharMohapatra07
Copy link
Contributor

Is this issue still open for contributions ? @dfarr @Madraceee

@Madraceee
Copy link
Contributor

@TusharMohapatra07 I have written the code, i just need clarifications from the team

@dfarr
Copy link
Member Author

dfarr commented Oct 23, 2024

Awesome @Madraceee! Please open a PR and we will review :)

@flossypurse
Copy link
Contributor

@Madraceee - just following up here on how we can help.

What do you need help clarifying?
We have a new channel in Discord dedicated to resonate engineering discussions (#resonate-engineering): https://resonatehq.io/discord

Feel free to hop in there to chat with us in realtime!

@flossypurse flossypurse moved this from Backlog to In progress in Resonate Engineering Dec 16, 2024
@flossypurse
Copy link
Contributor

Oh, sorry @Madraceee - seeing your PR here: #446

@flossypurse flossypurse linked a pull request Dec 16, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants