Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possibility of non atomic promise+task creation for CreatePromiseAndTask #514

Open
avillega opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@avillega
Copy link
Contributor

avillega commented Jan 9, 2025

Problem:

In some instances it is possible to end up with the creation of and claim of a task where the promise was not created. This happens because on conflict for promise creation we do nothing and continue as if the promise was created.

Describe the solution you'd like

Make promise creation fail on conflict. This will require a small refactor given that we still need to ignore creation conflicts when dealing with promises created by schedules.

Additional context

We found this behaviour when doing Callback+Promise creation. Given that this operation doesn't need to be atomic we split the two operations. However, we can do the same for Task+Promise creation given that this operation needs to be atomic.

@avillega avillega added the enhancement New feature or request label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant