Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization of the environments with regard to naming, credentials and .env/webroot solution #61

Open
moke13-dev opened this issue Nov 12, 2023 · 3 comments
Assignees

Comments

@moke13-dev
Copy link
Contributor

Would it be possible to standardize the enviroments more in terms of defaults, e.g. naming of databases, credentials, and so on as well as the handling of the webroot and the .env files.

With regard to the defaults for the databases and other credentials, such as backend credentials via bootstapping, it would be easiest if the user and password are always "reward" or "rewardenv". In addition, the database names should correspond to the enviroment name (reward_env_name).

This would be uniform for all enviroments and would be easier to remember.

In addition, handling the enviroments with the webroot is unattractive because, depending on the enviroment type,
sometimes the .env is contained in the actual project, sometimes it is outside the project or sometimes an .env contains both the application configuration and the reward configuration.

My suggestion would be to either rename the reward .env file to e.g. .env.reward or move it to the .reward directory in the project, so that the collision with the project .env files is avoided.

Copy link

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
@janosmiko janosmiko reopened this Dec 3, 2023
@github-actions github-actions bot removed the Stale label Dec 4, 2023
@janosmiko janosmiko self-assigned this Dec 12, 2023
@janosmiko
Copy link
Contributor

Hi @moke13-dev ,

These suggestions are also more than welcome. When I started this project, I wanted to be fully compatible with Warden. The webroot solution is also something we inherited from Warden, I strongly agree with the changes you suggested. I was also thinking about it previously, I planned to add support for environment files in the following order:

  1. .reward/reward.yml (or something similar)
  2. .reward/.env
  3. .env

If the first or the second configuration file exists, then those could be used. If not, then go with the third one. This would keep backward compatibility with the already existing environments and also a step forward.

And I would also keep the webroot functionality as a fallback option, as I already saw projects where the git repo contained a web or src folder and the Magento code was placed in that directory.

I'm open to discussion

Copy link

This issue is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@janosmiko janosmiko removed the Stale label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants