From 3f8806ceef84d487c9173d4e879eae4ea470a6d3 Mon Sep 17 00:00:00 2001
From: Stan <cyclinglinguist@gmail.com>
Date: Wed, 6 Dec 2023 08:59:42 -0600
Subject: [PATCH] Fixes for bugs #1574 #1575 (#1576)

* fix: correctly retrieve payloadFile argument
* fix: don't try to read prop from nullish element
* fix: log uncaught exceptions
  e.g. expired personal access token

---------

Co-authored-by: Stan Stanislaus <stan.stanislaus@steffesgroup.com>
Co-authored-by: Richard Fennell <bm-richard.fennell@outlook.com>
---
 .../src/GenerateReleaseNotesConsoleTester.ts                | 2 +-
 .../src/ReleaseNotesFunctions.ts                            | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/GenerateReleaseNotesConsoleTester.ts b/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/GenerateReleaseNotesConsoleTester.ts
index d380dd45c..065c99a48 100644
--- a/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/GenerateReleaseNotesConsoleTester.ts
+++ b/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/GenerateReleaseNotesConsoleTester.ts
@@ -14,7 +14,7 @@ async function run(): Promise<number> {
       var gitHubPat = argv["githubpat"];
       var bitbucketUser = argv["bitbucketuser"];
       var bitbucketSecret = argv["bitbucketsecret"];
-      var payloadFile = argv["payloadfile"];
+      var payloadFile = argv["payloadFile"];
 
       var showUsage = false;
       if (!filename || filename.length === 0) {
diff --git a/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/ReleaseNotesFunctions.ts b/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/ReleaseNotesFunctions.ts
index 0a35f33fe..a4e6d0ed7 100644
--- a/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/ReleaseNotesFunctions.ts
+++ b/Extensions/XplatGenerateReleaseNotes/XplatGenerateReleaseNotesTask/src/ReleaseNotesFunctions.ts
@@ -91,6 +91,10 @@ import { stringify } from "querystring";
 import { Exception } from "handlebars";
 import { IdentityDisplayFormat } from "azure-devops-node-api/interfaces/WorkInterfaces";
 
+process.on("uncaughtException", (error) => {
+  console.error("Uncaught Exception:", error);
+});
+
 let agentApi = new AgentSpecificApi();
 
 export function getDeploymentCount(environments: ReleaseEnvironment[], environmentName: string): number {
@@ -968,7 +972,7 @@ export function processTemplate(
         handlebars.registerHelper("lookup_a_work_item", function (array, url) {
             var urlParts = url.split("/");
             var wiId = parseInt(urlParts[urlParts.length - 1]);
-            return array.find(element => element.id === wiId);
+            return array.find(element => element?.id === wiId);
         });
 
         // add our helper to find test configuration