Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot gallery, guidelines, axes section, color scheme #65

Open
OskaratOmni opened this issue Jan 12, 2024 · 1 comment
Open

ggplot gallery, guidelines, axes section, color scheme #65

OskaratOmni opened this issue Jan 12, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@OskaratOmni
Copy link
Collaborator

reviewer comment: in the Axes section plus FIRST chart titled "4-Cylinder vehicles get better gas mileage on average." small thing but I wonder if we should have the bars be all the same color? I think this would better align them with our color guidance since the colors aren't really needed in these bar charts.

  • typically we have one or two bars that are emphasis colors (teal or blue) and the rest are grey - we don't have bar charts where each bar is a different color (see template examples)
  • even tho the guidance is about axes, please edit to have eitiher all bars a grey color or one bar emphsaized with an accessible chart title like "4 cylinder cars have higher mpg than 6 or 8 cylinder cars" [since this is an mtcars example the specifics of the title aren't too important].
  • we do sometimes say things like "all groups were represented in the sample" with all the bars the same color, but typically we have an emphasis or call out color a group or two.

Likewise, the typical OMNI graphic will have a graph title that is color coded to match the bar that is being emphasized in the bar chart.
image

Can this be added to the general guidance?

@tvroylandt tvroylandt added the documentation Improvements or additions to documentation label Jan 17, 2024
@dgkeyes
Copy link
Member

dgkeyes commented Jan 17, 2024

I've made the changes. I also changed a few of the other graphs to make things more consistent.

Please see https://stupendous-biscuit-9f1c75.netlify.app/ggplot-guidelines. @OskaratOmni let me know what you think.

@dgkeyes dgkeyes self-assigned this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants