Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClose triggers twice #18

Open
hazelf42 opened this issue Sep 21, 2020 · 0 comments
Open

onClose triggers twice #18

hazelf42 opened this issue Sep 21, 2020 · 0 comments

Comments

@hazelf42
Copy link

hazelf42 commented Sep 21, 2020

Hi there. When toggling the visibility, it seems to get called twice.


function toggleModalVisible() {
    setModalVisible(!modalVisible);
  }

        <Overlay
          visible={modalVisible}
          closeOnTouchOutside
          onClose={toggleModalVisible}
        >
          {(hideModal) => (
            <SettingsOverlay
              toggleModalVisible={toggleModalVisible}
              hideModal={hideModal}
              endStory={endStory}
              storyId={storyId}
            />
          )}
        </Overlay>

//SettingsOverlay:
     <View style={styles.exit}>
        <IconButton
          icon="close"
          size={20}
          onPress={toggleModalVisible} // (also double-fires when this is props.hideModal)
        />
      </View>

Is the relevant part.

This seems to happen if I use the toggle modal visible, or hideModal. It happens for both when the close button is pressed, and when touched outside.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant