-
Notifications
You must be signed in to change notification settings - Fork 1
Initialize Java runtimes config based on "Installed JREs" pref page #5
Comments
The full details error is:
|
There is one more which I guess is caused by this one:
|
To reproduce in empty workspace just create test project with module-info.java |
Have a look at https://github.com/eclipse/eclipse.jdt.ls/blob/5bdac979161b34cae73b9ed66733b5d867cce9d8/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JVMConfigurator.java#L202 . This gets called during initialization. So I think if you set Anything more advanced, and you'd probably want to use |
This is one of the issues that would automatically be fixed without effort or tweak if we can have JDT-LS running in a thread. |
So should we not look into this one but concentrate on the in-process or it's worth having it so we can actually start using jdt.ls.client now? |
The 3 currently knowb blockers for the in-process approach have fixes proposed as PRs and even if those fixes are not accepted as-it, the issue do seem relatively affordable to fix. So I've good hope that we can have in-process working in the IDE soon enough. I believe it's better to concentrate on it for a couple of weeks, and according to the outcome, either go full steam on it or revise the strategy to keep the LS external. |
Can you refer to the jdt.ls prs here for completeness? |
Current blockers are
I suspect there will be a few others in the future. |
Another blocker is eclipse-jdtls/eclipse.jdt.ls#2351 ; andother annoyign one (not blocker but really really hard to live with as it makes Eclipse IDE confused and breaking and requiring tons of hacks) is eclipse-jdtls/eclipse.jdt.ls#2348 |
I see "Unbound classpath container: 'JRE System Library [JavaSE-11]' in project 'org.eclipse.jdt.compiler.tool.tests'" from jdt.ls.client while testing it. Using the preferences of the IDE to fill the RuntimeOption[] as described in https://github.com/eclipse/eclipse.jdt.ls/wiki/Running-the-JAVA-LS-server-from-the-command-line#initialize-request should hopefully silence these.
The text was updated successfully, but these errors were encountered: