Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive logging #159

Open
seancribbs opened this issue May 9, 2011 · 4 comments
Open

Comprehensive logging #159

seancribbs opened this issue May 9, 2011 · 4 comments

Comments

@seancribbs
Copy link
Contributor

All major operations, especially communications with the Riak host, should be logged with a configurable logger object.

# Should use Rails' logger in the railtie
Riak.logger = Rails.logger

# Allow setting a custom logger
Riak.logger = Logger.new(STDOUT)

It could default to a 'null' logger.

@ntalbott
Copy link
Contributor

Is this still outstanding? Would love more comprehensive logging (especially if it included basic benchmarking like ActiveRecord provides).

@seancribbs
Copy link
Contributor Author

Yes, very outstanding. Something pluggable (e.g. using ActiveSupport::Notifications) might be nice, so you could turn it on or off and instrument.

@seancribbs
Copy link
Contributor Author

@ntalbott Also note this is in the "1.1" milestone.

@IdahoEv
Copy link
Contributor

IdahoEv commented Apr 11, 2012

Just want to add a thumbs up for this issue. Right now, debugging errors in the generated Riak queries requires putting debugging lines or puts lines in riak-client, which is a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants