Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting rails db:* tasks #317

Open
StabbyCutyou opened this issue Apr 5, 2013 · 3 comments
Open

Avoid overwriting rails db:* tasks #317

StabbyCutyou opened this issue Apr 5, 2013 · 3 comments

Comments

@StabbyCutyou
Copy link

This is effectively a clone of #313 , but specifically for the v1.0.0.beta2 tag

We're currently using this tag, but the rake task integration is a major problem that was recently uncovered.

The fix presented in the above PR is exactly what we need, but it has not been reflected anywhere other than master.

I have a branch created in my fork that handles this, but I'm not really sure how best to request integrating it, as tags are usually immutable, and I cannot perform a PR into one.

Perhaps a beta3 tag with this change?

Please advise

https://github.com/StabbyCutyou/ripple/tree/v1.0.0.beta3

@thunder-
Copy link

thunder- commented Apr 5, 2013

Yes that would be nice if there could be a new release tag added to rubygems, also because it would solve #308 which we're now working around for ..

Thanks :)

@StabbyCutyou
Copy link
Author

Actually, I would prefer if this only changed the rake tasks issue - We do want to move to an upgraded version of the riak client, but as we're using that in some legacy areas in a few specific ways, we don't want to make that change just yet.

By keeping this tag at it's current requirement level, you're still free to require a higher level version of the client yourself directly, as is my understanding of how gems work. By changing it, you'd be forcing an upgrade.

@StabbyCutyou
Copy link
Author

@seancribbs any chance I could get some feedback on your willingness to put out a new tag with the rake task fix, so that we don't need to rely on master?

I can also just use my own fork, but I figure this is the kind of thing others may want, while wanting to standardize on a tag, instead of master (which could change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants