-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoscaling #11
Comments
Hi @andreiashu You are right about the fact that the cli doesn't support this. For this to work a couple of things need to be done:
What do you think? I'm open for better naming. Is this something you want to work on? |
yeah that makes sense and I can put the time into this. One thing that could be confusing is having 2 ways of managing the configuration of the logentries agent. So my suggestion would be to go with the config approach and ditch the CLI one going forward. Unless there is something that the CLI approach provides which the config file approach doesn't. Let me know your thoughts. |
Good point. Only reason to keep the CLI way is for backwards compatibility. After reading everything again I would opt for a different variable name, e.g. In the future we can remove this method all together and bump version to 2.0.0 so it's clear we introduced a BC break. Sounds like a plan? |
Hi,
As far as I can see it looks like this role doesn't support the autoscaling feature of logentries. The LE documentation (https://logentries.com/doc/linux-agent-autoscaling/) mentions that the config would need to set
pull-server-side-config=False
and set thedestination
parameter for each file/path.I was wondering whether you had any suggestions for adding support for this? I tried to work on a PR but I think the le agent only supports the
destination
parameter via the config file and not the CLI. Thoughts?The text was updated successfully, but these errors were encountered: