-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look at ASCIIDoc extension to list tables and figures #25
Comments
I tested it out manually and it WAI. PR to add it to the docker image: riscv/riscv-docs-base-container-image#6 |
Is that extension good enough? I had intended on implementing this one: https://gitlab.com/baiyibai/asciidoctor-pdf-lofte which adheres the asciidoctor-pdf's TOC formatting and is also style-able. |
I wasn't aware of this other plugin. My hope was we'd find something that worked with both pdf and html output. This one does: https://github.com/Alwinator/asciidoctor-lists but I do see that it has some features missing that we might care about (pg number on list?) and the pdf styling may not be honored. I'll take a look at both and let you know. |
asciidoctor-listsusing latest release: https://github.com/Alwinator/asciidoctor-lists/releases/tag/v1.0.9 Findings:
asciidoctor-pdf-lofteusing the latest release: asciidoctor-pdf-lofte Here's branch of changes to example spec: https://github.com/kbroch-rivosinc/riscv-cfi/tree/dev/kbroch/try-asciidoctor-pdf-lofte Findings:
My recommendationGiven |
Filed issue on |
Thanks @kbroch-rivosinc I agree, we should move forward with asciidoctor-lists for now. |
This works fine if I can imagine wanting to use both of these parameters: |
The only other feature I can see wanting currently is page numbers: Alwinator/asciidoctor-lists#14. |
Lists of Tables/List of Figures has been raised as a possible addition to Unpriv and Priv. See riscv/riscv-isa-manual#1532 I have created a Branch from that issue and added Lof/Lot to Priv and Unpriv there. Note that only figures & tables with captions get picked up, which makes sense as asciidoctor needs to populate the list with some text. I have opened a discussion with Andrew W. in that issue for thoughts on moving forward. You can also either grab PDFs with the lists included from the Actions tab here https://github.com/riscv/riscv-isa-manual/actions/runs/9940634186 or run the Build ISAs action against that branch. |
No description provided.
The text was updated successfully, but these errors were encountered: