-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronization in format across specification #37
Comments
For # 1, also use "application processor" instead of "Application Processor" (no capital letter in the first letter), same for "Platform Microcontroller". I can take this change and # 2 change |
Leave the Base, System Reset and Suspend, since i am preparing PRs locally and have made changes for these groups |
Okay. |
Yeah, leave them completely. All points I have taken care already |
@lftan @@yeongjoshua Updated another case for error code above in the description. Let know your thoughts |
Okay. Please update |
Item # 1 and # 2 fix in #42 |
For "Return Status Code", do you think we want change to "Return status code". Remove unnecessary capital letters. |
In the description of the table for each parameter, some with full stop ".", and some do not. |
@pathakraul Does the picture need to use 'Application Processor' and 'Platform Microcontroller' instead? |
Creating this issue to list the items which should have same format across the specification. Lets keep updating this list here as we find them.
application processor
instead of AP. Useplatform microcontroller
instead of PuC.(service_id: 0xXY)
appended.eg.
Service: SYSRST_GET_ATTRIBUTES (service_id: 0x02)
.RESERVED and must be 0
.5. Use the*_NOT_FOUND
error code for request parameter which directly represents resource for that service group and for rest of the parameters*_INVAL
.5. Use the
*INVALID_PARAM
for all parameters passed to a service if invalid or not supported. At some places if we have a specific defined error then we can use that, for example invalid address has*INVALID_ADDR
For example in Clock service group(get attributes service) -
clock_id
if not valid returnRPMI_ERR_NOT_FOUND
and for rest of the parameters likeCLOCK_RATE_INDEX
in this service should beRPMI_ERR_INVAL
.similarly, in case of CPPC service group (probe register service),
REG_ID
must haveRPMI_ERR_NOT_FOUND
and forHART_ID
it should beRPMI_ERR_INVAL
Since we have sufficient error codes and we can use for distinct error conditions
The text was updated successfully, but these errors were encountered: