Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants.py is duplicated between riscv-opcodes and riscv-config? #165

Open
tovine opened this issue Feb 27, 2023 · 4 comments
Open

Constants.py is duplicated between riscv-opcodes and riscv-config? #165

tovine opened this issue Feb 27, 2023 · 4 comments

Comments

@tovine
Copy link
Contributor

tovine commented Feb 27, 2023

Seems very much like it is, should ideally be merged to a single source of truth and/or the one in this repository should get the same improvements as this? riscv-software-src/riscv-config#105

@neelgala
Copy link
Collaborator

They are not duplicated. I have used "constants" has a naming convention for a file holding manually defined constants. The constants.py file in opcodes and riscv-config is drastically different and used for completely different use-cases.

@tovine
Copy link
Contributor Author

tovine commented Feb 27, 2023

I see, but the list of extensions (and isa_regex) is still duplicated (and inconsistent!) between the two. Is there a way to have one of them be the "master" and include the other?
I guess having riscv-opcodes the main source of truth would make sense since it's the first one to be updated.

EDIT: also the isa_regex in this one currently has the same issues as I addressed in the linked PR for riscv-config

@neelgala
Copy link
Collaborator

isa_regex in opcodes is probably useless.. I don't see any references to it and thus can be removed.
Thus, the RISC-V config version must be considered golden in this case

@tovine
Copy link
Contributor Author

tovine commented Feb 27, 2023

Good. This of course needs to be investigated, as it might be used in various other repositories that use this as a submodule, but it sounds like a good idea to remove it if unused (and any such dependents should in that case be modified to use the one from riscv-config instead)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants