Change *_reservation to take physaddr #676
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Jan 9, 2025
| @@ -68,3 +67,13 @@ struct zMcause { | |||
| extern struct zMcause zmcause, zscause; | |||
|
|
|||
| extern mach_bits zminstret; | |||
|
|
|||
| enum kind_zphysaddr { Kind_zphysaddr }; | |||
There was a problem hiding this comment.
Having to duplicate this sail-internal representation does not sound like a good idea to me. IMO the C callback should just use the underlying bits.
There was a problem hiding this comment.
If/when we switch to the struct Model { #include "model.c" } trick then we won't have to do this. But I agree, it's too error-prone until it's actually checked by the compiler.
arichardson
requested changes
Jan 9, 2025
There was a problem hiding this comment.
I think this just makes it more difficult to read for no real gain. If we want to ensure that load_reservation takes a physaddr we should make it a sail function that calls the C function with the raw bits. Not sure this adds much value over the current physaddrbits though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #670, edit Sail's C language code so that the load_reservation and match_reservation functions can accept physaddr type parameters