-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ropchain constraint syntax parser #4552
Conversation
TODO: |
Current output:
Added support for stack change Another eg:
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better! Only few small nitpicks left, apart from that - LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Next time please use different branch name, by the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge improvements. fix the comments i left and i think we can merge.
Current ROP chain parser misses some gadget when compared with the ROPGadget
Asm:
ROPgadget output:

Rizin output before

Rizin output now:

These ROP gadgets are needed for crafting better rop chains.
Partially fix: #2080
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...