-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruler to histogram output #4776
base: dev
Are you sure you want to change the base?
Add ruler to histogram output #4776
Conversation
In such PRs (related to UI) please attach screenshots. |
@DimitrisVita I think such ruler should be moved to the left, not the right. Or this can be one more histogram option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think, that while vertical ruler should be added to horizontal histogram, horitzontal ruler should be added to vertical histogram.
b45d2c6
to
ab9a6cf
Compare
@DimitrisVita hi, have you had some time to continue working on this? |
@DimitrisVita if you have any questions, don't hesitate to ask them on the Rizin Dev channel on our Mattermost. |
Your checklist for this pull request
Detailed description
This pull request adds a vertical ruler to the horizontal histogram output in
librz/cons/histogram.c
. The ruler includes value ranges and uses a vertical Unicode line character ifscr.utf8=true
.I've added y-axis numbering, which is computed as 255 - threshold, where the threshold is calculated for each row. Please let me know if this approach is acceptable or if any adjustments are needed. Should it be added to the interactive histogram too?
Here are two images showing the expected output:
p== 50
withscr.utf8=true
p== 50
withscr.utf8=false
Test plan
scr.utf8=true
in the configuration.p==
command.scr.utf8=true
and repeat the test to ensure the ruler is displayed correctly without Unicode characters.Closing issues
Addresses #129 but might need improvement