Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MIPS IL for addi, move and negu #4916

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix MIPS IL for addi, move and negu #4916

merged 1 commit into from
Feb 20, 2025

Conversation

wargio
Copy link
Member

@wargio wargio commented Feb 19, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

Fixes move and negu aliases which were not detected and addi which was setting a fake register which is not currently supported.

@wargio wargio changed the title Fix addi, move and negu Fix MIPS IL for addi, move and negu Feb 19, 2025
Rot127
Rot127 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue about it: capstone-engine/capstone#2628

@wargio wargio merged commit e742a10 into dev Feb 20, 2025
49 checks passed
@wargio wargio deleted the fix-mips-il branch February 20, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@notxvilka notxvilka notxvilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
MIPS rz-test RzAnalysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wargio @Rot127 @notxvilka