Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to skip string detection during ptr printing. #4917

Closed
wants to merge 1 commit into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Feb 19, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

Test to see how much stuff fails with this. Attempts to improve performance.

Test plan

...

Closing issues

...

Copy link
Contributor

@notxvilka notxvilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad, only 2 tests are failing:

[XX] 749 ms   db/analysis/x86_64 auto string memory reference (io.va)
RZ_NOPLUGINS=1 /home/runner/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -qc 'e asm.sub.rel=false
e asm.arch=x86
e asm.bits=64
e scr.color=false
e io.va=1
e asm.lines.bb=0
e asm.bytes=0
e asm.cmt.right=10
wx 488b3541100000
wv8 0x500 @ 0x1048
w Hello @ 0x500
pd 1
' malloc://8096
-- stdout
--- expected
+++ actual
@@ -1,2 +1,2 @@
-  ; [0x1048:8]=0x500 "Hello"
+  ; [0x1048:8]=0x500
   0x00000000      mov rsi, qword [rip + 0x1041]

@Rot127
Copy link
Member Author

Rot127 commented Feb 20, 2025

It seemed to give only marginal improvements (compared to this run: https://github.com/rizinorg/rizin/actions/runs/13412727755/job/37466351505. Not more then a minute)

And while comparing runtimes don't really make sense, it is not worth it. Especially since the other improvements (reducing allocations and frees in process_one_string(): 60e885d) are just so so much more impactful.

@Rot127 Rot127 closed this Feb 20, 2025
@Rot127 Rot127 deleted the skip_str_detection branch February 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants