Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using x86.as assembler fails on non-x86 systems. #4941

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Using x86.as assembler fails on non-x86 systems. #4941

merged 1 commit into from
Feb 27, 2025
+4 −4

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Feb 26, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

...

Test plan

...

Closing issues

...

wargio
wargio approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86.as requires to have the external assembler.

@wargio wargio merged commit 14d50bb into dev Feb 27, 2025
59 checks passed
@wargio wargio deleted the dist-fix-search-a branch February 27, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
rz-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @wargio