Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Clear progress before results #4943

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Feb 27, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).

Detailed description

The search progress notification is of significant length, so if the first result line is short, then there will be an unwanted tail, e.g.

slash-z-first-has-tail

due to use of just \r. This pr clears the last progress notification before printing the results so the above will not happen. It also sleeps first before printing search progress, rather than the other way around, to prevent unnecessary flicker.

Test plan

All builds are green. Test may be racy, but hopefully CI computers are fast enough.

Closing issues

...

@kazarmy kazarmy merged commit 1705dae into rizinorg:dev Feb 27, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants