Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview build has broken image paths #210

Closed
drmowinckels opened this issue Sep 1, 2023 · 1 comment
Closed

Preview build has broken image paths #210

drmowinckels opened this issue Sep 1, 2023 · 1 comment

Comments

@drmowinckels
Copy link
Member

drmowinckels commented Sep 1, 2023

I think when I did the change to the hugo profiles, I might have made some change that breaks the paths to images in the previews that are made.

example
https://6043692888--rladies-dev.netlify.app/directory

@drmowinckels
Copy link
Member Author

had a peak atht the rendered html and found:

<img src="https://rladies.org/directory/alessia-visconti_hu6200f6eb60224859786202e032d821b9_54468_300x300_fill_box_smart1_3.png">

So its seems like the baseurl of the preview is not changed, meaning the bit in the workflow that should switch to building with a specific baseurl is not being triggered.

https://github.com/rladies/rladies.github.io/blob/main/.github/workflows/build.yaml#L132-L139

I believe switching the if statement in line 134 to the one below should fix it.

if [[ '${{github.ref}}' == 'refs/heads/main' &&  ${{github.event_name}} != 'workflow_dispatch']]; then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant