Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ODE parameters #22

Open
robin-janssen opened this issue Nov 14, 2024 · 0 comments
Open

Add support for ODE parameters #22

robin-janssen opened this issue Nov 14, 2024 · 0 comments
Labels
Feature Idea/request for a new feature

Comments

@robin-janssen
Copy link
Owner

There are many cases where in addition to the initial conditions of the ODE, external parameters like density, radiation flux or temperature could influence trajectories, where identical initial conditions evolve differently based on these external parameters. While they could be treated as species that remain constant over the course of the time-evolution, this does not capture the nature of these quantities and their interaction with the time-evolution of the chemical abundances.

We need the option to add parameters to the dataset. These will be assumed to be constant for any sample over the course of the time-evolution.
This must be implemented into each surrogate, the create_dataloader method as well as into the create_dataset function.

@robin-janssen robin-janssen added the Feature Idea/request for a new feature label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Idea/request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant