Simplify code for ensemble of simulated paths #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to drop the tsibble class when combining sample paths to produce an ensembled fable. Reducing the row structure over
.model
can be done directly withsummarise()
.I would also have placed
.model = "ENSEMBLE"
in thesummarise()
call, but there is a bug with tsibble: tidyverts/tsibble#214. Generally speaking, the.model
column should not be necessary in a fable (tidyverts/fabletools#96), but many functions in fabletools still assume it exists (likeaccuracy()
) and need updating. The.mean
column is also entirely optional, as all required statistics are computed directly from the distribution now.