Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code for ensemble of simulated paths #1

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Simplify code for ensemble of simulated paths #1

merged 1 commit into from
Aug 9, 2020

Conversation

mitchelloharawild
Copy link
Contributor

@mitchelloharawild mitchelloharawild commented Aug 9, 2020

There is no need to drop the tsibble class when combining sample paths to produce an ensembled fable. Reducing the row structure over .model can be done directly with summarise().

I would also have placed .model = "ENSEMBLE" in the summarise() call, but there is a bug with tsibble: tidyverts/tsibble#214. Generally speaking, the .model column should not be necessary in a fable (tidyverts/fabletools#96), but many functions in fabletools still assume it exists (like accuracy()) and need updating. The .mean column is also entirely optional, as all required statistics are computed directly from the distribution now.

@mitchelloharawild mitchelloharawild changed the title Simplify code for ensemble from of simulated paths Simplify code for ensemble of simulated paths Aug 9, 2020
@robjhyndman robjhyndman merged commit 5e743eb into robjhyndman:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants