Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service level RobotId proto default value usage #78

Open
fnalmeidap opened this issue Oct 30, 2024 · 0 comments
Open

Service level RobotId proto default value usage #78

fnalmeidap opened this issue Oct 30, 2024 · 0 comments
Labels
debt Postponed implementations

Comments

@fnalmeidap
Copy link
Member

fnalmeidap commented Oct 30, 2024

Currently, RobotId proto messages sent for the robot number 0 does not have the mandatory field RobotId.number because protobuf 3 does not serialize default values (see here).

As explicit typing this field as optional is a semantic mislead but employs desired behavior of field serialization when default values are set.

A better approach should be implemented to deal with this issue so we can have semantic coherence alongside functionality. A possible solution was discussed at #51

@fnalmeidap fnalmeidap added the debt Postponed implementations label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Postponed implementations
Development

No branches or pull requests

1 participant