Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise image loading code #2

Open
sole opened this issue Mar 30, 2012 · 1 comment
Open

Optimise image loading code #2

sole opened this issue Mar 30, 2012 · 1 comment

Comments

@sole
Copy link
Contributor

sole commented Mar 30, 2012

Currently the entire images are loaded and then downsampled if required. This could be optimised by not loading the entire image if possible (then adjusting to match the maximum size).

Also the code for loading images is scattered & somehow duplicated in several files (RarComic.getBitmapFromFileHeaderIfNeeded, ZipComic.getBitmapFromEntryIfNeeded, FolderComic.resampleAndSave) so that could maybe be refactored.
@hpique
Copy link
Member

hpique commented Mar 30, 2012

Theoretically images are downsampled only if needed. Once downsampled the resulting image is saved into the SD card and then read from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sole @hpique