New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue during gtm integration tests with ajax request #31

Open

killmenot opened this issue Nov 27, 2017 · 0 comments

killmenot commented Nov 27, 2017

Environment:

express
gtm

Please take a look:

qewd/lib/appHandler.js

Line 292 in cbf87ac

session.socketId = messageObj.socketId;

I found that app crushed on this line with error:

I think this line should be replaced to

if (messageObj.socketId) session.socketId = messageObj.socketId;
if (messageObj.ipAddress) session.ipAddress = messageObj.ipAddress;

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment