From ed387e5f1d4b3bd4a4a442f8a048a608e69d73c1 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Sun, 29 Dec 2024 08:23:39 +1100 Subject: [PATCH 1/2] hashes: Hide both macros We have two macro definitions feature gated on `serde`. At some stage we added the `doc(hidden)` attribute to one of them but forgot to add it to the other. This technically makes our features non-additive. This macro is "internal" so its unlikely that this is being used in the wild. Add `doc(hidden)` to the `serde_impl` macro that is missing it. Found by `cargo semver-checks` after recent upgrade to 0.38 --- hashes/src/macros.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/hashes/src/macros.rs b/hashes/src/macros.rs index 3d5382aec..dc134577a 100644 --- a/hashes/src/macros.rs +++ b/hashes/src/macros.rs @@ -533,6 +533,7 @@ macro_rules! serde_impl( )); /// Does an "empty" serde implementation for the configuration without serde feature. +#[doc(hidden)] #[macro_export] #[cfg(not(feature = "serde"))] macro_rules! serde_impl( From 87293dfdd38be71938ae9d6a9981eb4569de3521 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Sun, 29 Dec 2024 08:42:34 +1100 Subject: [PATCH 2/2] api: Run just check-api --- api/hashes/alloc-only.txt | 1 - api/hashes/no-features.txt | 1 - 2 files changed, 2 deletions(-) diff --git a/api/hashes/alloc-only.txt b/api/hashes/alloc-only.txt index 50246e2d4..93d5bf78e 100644 --- a/api/hashes/alloc-only.txt +++ b/api/hashes/alloc-only.txt @@ -859,7 +859,6 @@ pub fn bitcoin_hashes::siphash24::State::fmt(&self, f: &mut core::fmt::Formatter pub macro bitcoin_hashes::hash_newtype! pub macro bitcoin_hashes::impl_debug_only_for_newtype! pub macro bitcoin_hashes::impl_hex_for_newtype! -pub macro bitcoin_hashes::serde_impl! pub macro bitcoin_hashes::sha256t_hash_newtype! pub macro bitcoin_hashes::sha256t_tag! pub mod bitcoin_hashes diff --git a/api/hashes/no-features.txt b/api/hashes/no-features.txt index 5283250bd..e1ce22551 100644 --- a/api/hashes/no-features.txt +++ b/api/hashes/no-features.txt @@ -806,7 +806,6 @@ pub fn bitcoin_hashes::siphash24::State::clone(&self) -> bitcoin_hashes::siphash pub fn bitcoin_hashes::siphash24::State::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result pub macro bitcoin_hashes::hash_newtype! pub macro bitcoin_hashes::impl_debug_only_for_newtype! -pub macro bitcoin_hashes::serde_impl! pub macro bitcoin_hashes::sha256t_hash_newtype! pub macro bitcoin_hashes::sha256t_tag! pub mod bitcoin_hashes