Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot "upgrade" from get to get -vcs #30

Open
myitcv opened this issue Oct 12, 2018 · 1 comment
Open

cannot "upgrade" from get to get -vcs #30

myitcv opened this issue Oct 12, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@myitcv
Copy link
Collaborator

myitcv commented Oct 12, 2018

Effectively reproduced by:

> [!net] skip
> [!exec:git] skip
> env GOPROXY=
> cd repo
> go get rsc.io/[email protected]
> env GOHACK=/gohack
> gohack get rsc.io/quote
rsc.io/quote => /gohack/rsc.io/quote
> gohack undo
> gohack get -vcs rsc.io/quote

I think this issue also raises the question of how you "downgrade" in the case you subsequently call bare get (because the assumption would be, in that case, that you aren't working in a VCS checkout).

@rogpeppe rogpeppe added the enhancement New feature or request label Oct 17, 2018
@mvdan
Copy link
Collaborator

mvdan commented Nov 5, 2018

Just encountered this myself:

$ gohack get -vcs github.com/rogpeppe/go-internal
cannot update VCS dir for github.com/rogpeppe/go-internal: cannot get info: cannot get VCS info from "/home/mvdan/gohack/github.com/rogpeppe/go-internal": fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
all modules failed; not replacing anything
$ # remove ~/gohack
$ gohack get -vcs github.com/rogpeppe/go-internal
creating github.com/rogpeppe/[email protected]
github.com/rogpeppe/go-internal => /home/mvdan/gohack/github.com/rogpeppe/go-internal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants