Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assertEqual to allow different number types #304

Open
markwpearce opened this issue Nov 15, 2024 · 2 comments
Open

Allow assertEqual to allow different number types #304

markwpearce opened this issue Nov 15, 2024 · 2 comments

Comments

@markwpearce
Copy link
Collaborator

Normally, you don't really care if a value is a float vs. an integer

so m.assertEqual(70.0, 70) should not fail a test

@TwitchBronBron
Copy link
Member

@chrisdp you've done a lot of work on the tests lately. Thoughts on this? (Or an alternative assertion function)

@chrisdp
Copy link
Collaborator

chrisdp commented Jan 24, 2025

I personally like the idea but worry about breaking existing tests. I was thinking we would tackle some of this with a new set of expects or asserts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants