Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove login endpoint #225

Open
shurwit opened this issue Aug 22, 2022 · 0 comments
Open

[TASK] Remove login endpoint #225

shurwit opened this issue Aug 22, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@shurwit
Copy link
Collaborator

shurwit commented Aug 22, 2022

Description

Currently there is a /login API that must be called to update the user data in the users collection. I do not believe this API should be necessary as we can achieve a similar result by checking if the user data is up to date whenever any API is called with their token.

This login process also contains a migration process intended to update users to use the Core BB. At this point, I believe this process can safely be removed to reduce overhead and simplify logic.

Edit: As of 8/24, there were 434 non-core users out of 70966 users in the prod users collection.

Acceptance Criteria

Whenever a user accesses an API with their token, we should check to see if the user exists, then check if any of their stored data has changed. If it has, we apply an update to the users collection and all memberships with the latest data from the token.

In order to reduce unnecessary database calls, we can cache the user data from the database for some time so subsequent requests will not result in db calls unless the token data changes.

@shurwit shurwit added the enhancement New feature or request label Aug 22, 2022
@shurwit shurwit added this to the v2.0.0 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant