Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add draft message support #4725

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[FEATURE] Add draft message support #4725

wants to merge 4 commits into from

Conversation

manav2modi
Copy link
Contributor

@manav2modi manav2modi commented Feb 3, 2025 •
edited
Loading

Description

Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Dependent on https://github.com/rokwire/social-building-block/pull/107
Dependent on rokwire/app-flutter-plugin#548
Fixes #4724

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@manav2modi manav2modi linked an issue Feb 3, 2025 that may be closed by this pull request
[FEATURE] Add draft message support #4724
Open
@manav2modi manav2modi mentioned this pull request Feb 3, 2025
Open
18 tasks
@mihail-varbanov
Copy link
Collaborator

Hi @manav2modi, I will review this PR after #107 gets approved, merged and deployed on dev, so that I can test this feature in real. Meanwhile, I see 2 items that is good to get cleaned up:

1. It is not a good idea to submit the draft message at the state's disposal because it is not guaranteed when it will be called. I see two possible ways to get around handling this at dispose:

1.1. Handle back navigation. An example of this can be found in _MTDStopSearchPanelState, particularly pay attention to HeaderBar.onBack, PopScopeFix and _onHeaderBarBack usage. These are supposed to handle popping the panel from the back header bar button or by swipe gesture.

1.2. Listen for AppNavigation.notifyEvent.

2. displayDateTime.contains("9000") does not seem a good way to determine whether the last message type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihail-varbanov mihail-varbanov Awaiting requested review from mihail-varbanov mihail-varbanov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add draft message support
2 participants
@manav2modi @mihail-varbanov