Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the type of the library in Package.swift to .dynamic. #280

Open
rashadatjou opened this issue Apr 27, 2023 · 2 comments
Open

Setting the type of the library in Package.swift to .dynamic. #280

rashadatjou opened this issue Apr 27, 2023 · 2 comments

Comments

@rashadatjou
Copy link

Is your feature request related to a problem? Please describe.

Yes, the feature request is related to a problem I'm facing while building a framework that leverages Rollbar. Rollbar exposes its products as a static library. However, when compiling the framework for production, the static library is embedded in the framework, causing potential issues like code duplication and increased binary size.

Describe the solution you'd like

I would like a solution that provides an option to not embed the static library when compiling the framework for production. This could be done by adding the property type: .dynamic to all libraries exposed in the products property of Package.swift. If this would not be possible please expose dynamic version of already existing libraries.

Describe alternatives you've considered

One alternative would be to manually remove the static library from the framework after it has been compiled, but this would be a cumbersome and error-prone process that would need to be repeated for each build.

Additional context

The current behavior of embedding the static library during the framework compilation may lead to issues such as code duplication and increased binary size. By providing an option to avoid embedding the static library, users of the package can have better control over their build process and avoid potential issues related to static library embedding.

@rashadatjou
Copy link
Author

I have create a PR and tested it out with our Framework and it works.

#281

@ghost
Copy link

ghost commented May 24, 2023

Hey @rashadatjou, Thanks for reporting this issue, and I appreciate you created a PR too. Let me ask the devs to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant