Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize eslint and prettier for the entire project with ci checks #109

Closed
wants to merge 8 commits into from

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 23, 2024

Description of the change

This PR opinionatedly declares eslint as the default linter for rollbar-react, and prettier the default formatter, as is in Olympus.

The same formatting configuration as Olympus has been used and the build CI has been rewritten with updated actions, caching and a linting step that runs eslint and prettier.

Eslint configuration for each example has been made its own root eslint configuration to avoid grabbing the library's eslint config which defines plugins incompatible with apps.

Eslint ignore file has been added to avoid eslint linting the dist directory, and others.


ESLint warnings and errors have been fixed across all examples and library sources.

Prettier formatting has been applied across all examples and library sources.


I recommend going over the changes using the Unified diff view + hiding whitespaces.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 23, 2024
@matux matux force-pushed the matux/prettier branch 2 times, most recently from 2bd07af to 043e63e Compare February 24, 2024 00:02
@matux matux force-pushed the matux/prettier branch 2 times, most recently from 8137907 to b607549 Compare February 24, 2024 15:29
@matux matux changed the title Standardize prettier formatter and lint checks in ci Standardize eslint and prettier for the entire project with ci checks Feb 24, 2024
@matux matux closed this Feb 24, 2024
@matux matux deleted the matux/prettier branch February 24, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant